Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when using type aliases referencing other type aliases #10809

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix error when using type aliases referencing other type aliases #10809

merged 1 commit into from
Nov 12, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Nov 10, 2024 •
edited
Loading

Change Summary

Many thanks @kc0506 for the implementation.

Closes #10624, fixes #8984, seems like it fixes #8317.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 10, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 10, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07e5b51
Status: ✅  Deploy successful!
Preview URL: https://e2cd6db8.pydantic-docs.pages.dev
Branch Preview URL: https://fix-typealias.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10809 will not alter performance

Comparing fix-typealias (07e5b51) with main (c7a3d5c)

Summary

✅ 44 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _core_utils.py
Project Total  

This report was generated by python-coverage-comment-action

sydney-runkle
sydney-runkle approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this across the finish line, @Viicos!

@sydney-runkle sydney-runkle merged commit ff4a325 into main Nov 12, 2024
56 checks passed
@sydney-runkle sydney-runkle deleted the fix-typealias branch November 12, 2024 13:42
@Viicos Viicos mentioned this pull request Nov 18, 2024
Closed
1 task
@Viicos Viicos mentioned this pull request Dec 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
3 participants
@Viicos @sydney-runkle @kc0506