Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PydanticDeprecatedSince26 typo #10101

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix PydanticDeprecatedSince26 typo #10101

merged 2 commits into from
Aug 11, 2024

Conversation

kc0506
Copy link
Contributor

@kc0506 kc0506 commented Aug 11, 2024 •
edited
Loading

Change Summary

This looks like a typo😅

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 11, 2024

CodSpeed Performance Report

Merging #10101 will not alter performance

Comparing kc0506:fix-warning-typo (78dabf8) with main (07b7f64)

Summary

✅ 17 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  warnings.py 60
Project Total  

This report was generated by python-coverage-comment-action

@Viicos
Copy link
Member

Viicos commented Aug 11, 2024

Thanks for the fix!

@Viicos Viicos enabled auto-merge (squash) August 11, 2024 13:26
@Viicos Viicos disabled auto-merge August 11, 2024 13:26
@Viicos Viicos enabled auto-merge (squash) August 11, 2024 13:28
@Viicos Viicos merged commit bf710b9 into pydantic:main Aug 11, 2024
60 checks passed
@kc0506 kc0506 deleted the fix-warning-typo branch October 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kc0506 @Viicos