Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pycontw-2020/assets/keynotes): add wenyu-su #817

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

FrankYang0529
Copy link
Contributor

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (add static files)

Description

Describe what the change is
Add WenYu-Su keynote static files to pycontw-2020/assets/keynotes.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #817 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage   76.14%   76.29%   +0.14%     
==========================================
  Files          70       70              
  Lines        2687     2687              
==========================================
+ Hits         2046     2050       +4     
+ Misses        641      637       -4     
Impacted Files Coverage Δ
src/events/views.py 65.94% <0.00%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ecc4b...b3dc2b4. Read the comment docs.

@FrankYang0529 FrankYang0529 force-pushed the poanyang/add-keynote branch from 91b3362 to 8170795 Compare July 7, 2020 11:24
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last updat 🎉 We still need to update the English version of his bio to merge this PR.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update 🎉 @yychen This branch is now ready to merge. Do we need to wait for any other PRs?

@yychen yychen merged commit 1716b11 into pycontw:master Jul 14, 2020
@FrankYang0529 FrankYang0529 deleted the poanyang/add-keynote branch May 10, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants