Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigiBatt is added as the funding partner in the PyBOP high level image #627

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

Dibyendu-IITKGP
Copy link
Contributor

@Dibyendu-IITKGP Dibyendu-IITKGP commented Jan 16, 2025

Description

DigiBatt is added as a funding partner in the high-level PyBOP image.

Issue reference

Fixes #565

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • Documentation: Updates to documentation or new documentation for new features.

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@Dibyendu-IITKGP Dibyendu-IITKGP linked an issue Jan 16, 2025 that may be closed by this pull request
@Dibyendu-IITKGP Dibyendu-IITKGP self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (114770e) to head (fa92233).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #627      +/-   ##
===========================================
- Coverage    99.22%   99.22%   -0.01%     
===========================================
  Files           62       62              
  Lines         4498     4495       -3     
===========================================
- Hits          4463     4460       -3     
  Misses          35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
assets/PyBOP-high-level.svg Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a bit of a nitpick, it looks like the boxes "Experimental Data", "Parameter identification", and "Design Optimisation" have increased line spacing — would you mind restoring it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my bad, I'll fix right now.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Dibyendu-IITKGP!

@BradyPlanden BradyPlanden merged commit 3111a49 into develop Jan 23, 2025
31 checks passed
@BradyPlanden BradyPlanden deleted the 565-add-digibatt-as-funding-partner branch January 23, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DigiBatt as funding partner
2 participants