-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DigiBatt is added as the funding partner in the PyBOP high level image #627
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #627 +/- ##
===========================================
- Coverage 99.22% 99.22% -0.01%
===========================================
Files 62 62
Lines 4498 4495 -3
===========================================
- Hits 4463 4460 -3
Misses 35 35 ☔ View full report in Codecov by Sentry. |
assets/PyBOP-high-level.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, a bit of a nitpick, it looks like the boxes "Experimental Data", "Parameter identification", and "Design Optimisation" have increased line spacing — would you mind restoring it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, my bad, I'll fix right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @Dibyendu-IITKGP!
Description
DigiBatt is added as a funding partner in the high-level PyBOP image.
Issue reference
Fixes #565
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.