Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonttools.svgPath.path.parse_path() to replace svg.path? #525

Closed
gmischler opened this issue Sep 9, 2022 · 2 comments · Fixed by #545
Closed

fonttools.svgPath.path.parse_path() to replace svg.path? #525

gmischler opened this issue Sep 9, 2022 · 2 comments · Fixed by #545
Labels
code-quality enhancement research needed too complicated to implement without careful study of official specifications

Comments

@gmischler
Copy link
Collaborator

I just discovered that fonttools have a module "svgLib", containing a class svgLib.path, which again has a method parse_path().

I wonder if this could be used to replace the "svg.path" package that we currently use, reducing the number of dependencies for fpdf2 again.
@Lucas-C
Copy link
Member

Lucas-C commented Sep 13, 2022

This sounds interesting, well spotted @gmischler!

Have you checked their code quality / test coverage, and if they support as many use cases as svg.path?

@gmischler
Copy link
Collaborator Author

Have you checked their code quality / test coverage, and if they support as many use cases as svg.path?

Fonttools looks to be a very well maintained and active project, but other than that I haven't looked into the details of this specific module yet.

@Lucas-C Lucas-C added research needed too complicated to implement without careful study of official specifications and removed pending-answer labels Sep 13, 2022
@gmischler gmischler mentioned this issue Sep 17, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality enhancement research needed too complicated to implement without careful study of official specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch SVG path parsing to fonttools gmischler/fpdf2
2 participants
@Lucas-C @gmischler