Swift 3 and single target #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… optional so that if the builder fails to create a request for whatever reason, they can return nil
… notifying when susbscriptions fail/succeed when trying to subscribe.
… fails, refactor remaining logic to read more clearly.
Conditionally unwrap data before use during authorization request
Closed
hamchapman
force-pushed
the
single-target-swift-3
branch
from
8bbcbdb to
025b62e
Compare
hamchapman
force-pushed
the
single-target-swift-3
branch
from
e16447c to
dc0a8f3
Compare
|
Hi! Do you have any idea when the migration to Swift 3 will be finished? |
|
The Swift 3 migration itself is done. There's just a bit of tidy up to do in the docs / examples and then I think it's good to go for a 3.0.0 release. Feel free to try stuff out with this branch before I cut the release though. It all compiles and the tests pass etc. |
|
Awesome! Thanks! You will merge it and create a new version for Cocoapods today? |
|
Hopefully yes - need to do a few more bits and pieces first |
|
I didn't quite have time to release it yesterday but am going to do it |
state change delegate functions into combined PusherConnectionDelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestForinAuthRequestBuilderProtocolable to failPresencePusherChannel->PusherPresenceChannelinternalauthMethod enum case toinlinesubscribeToPresenceChannelmethod