Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change provider's name #296

Merged
merged 6 commits into from Nov 25, 2019
Merged

Allow to change provider's name #296

merged 6 commits into from Nov 25, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2019

Description

Allows to override the provider's name for the sign-in page.

Motivation and Context

It would be nice to be able to adjust the provider's name. This is mostly relevant for the OpenID Connect provider: the sign-in page could then be changed from Sign in with OpenID Connect to Sign in with ACME Inc. Login.

Fixes #295.

How Has This Been Tested?

Not yet tested.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@ghost ghost requested review from steakunderscore and loshz as code owners October 23, 2019 09:56
@ghost ghost self-requested a review October 23, 2019 09:56
loshz
loshz previously approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@loshz loshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Once the CHANGELOG conflict has been resolved we can get this merged.

@felixfontein
Copy link
Contributor

@syscll thanks! I've resolved the conflict, sorry I didn't notice it earlier...

loshz
loshz previously approved these changes Nov 9, 2019
View reviewed changes
@loshz
Copy link
Member

loshz commented Nov 9, 2019

@JoelSpeed @steakunderscore WDYT?

JoelSpeed
JoelSpeed reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided it has been tested then I'm happy for it to be merged

One thought that did come to mind however, is the name of the flag might be a bit ambiguous? Would it be more obvious that it is just a display name if it were called provider-custom-name or provider-display-name?

My worry is that people might think provider-name does the job of provider, do you think this could be a risk?

@ghost
Copy link
Author

ghost commented Nov 25, 2019

I rebased (resolve conflict), renamed the option from provider-name to provider-display-name (no idea whether provider-name will be misunderstood, but provider-display-name definitely won't - thanks for the idea!) and added a missing part. I've build the docker container and it works fine (with a new shiny provider display name in my use-case :) ).

@loshz
Copy link
Member

loshz commented Nov 25, 2019

Thank you and congrats on your first contribution! 🎉

@loshz loshz merged commit 11205c7 into oauth2-proxy:master Nov 25, 2019
@ghost ghost deleted the change-provider-name branch November 26, 2019 06:22
@ghost
Copy link
Author

ghost commented Nov 26, 2019

@syscll @JoelSpeed thanks for reviewing and merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steakunderscore steakunderscore Awaiting requested review from steakunderscore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: allow to change provider's name
3 participants
@felixfontein @loshz @JoelSpeed