Simplify and document ProductConfigReaderDerivation #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruippeixotog
force-pushed
the
simplify_scala3_product_derivation
branch
from
97ec754 to
0a97284
Compare
jcazevedo
force-pushed
the
simplify_scala3_product_derivation
branch
from
1208caf to
40b0397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies some parts of
ProductConfigReaderDerivationby avoiding index tracking when reading tuples and by reusing existing utility functions to deal withConfigReader.Result. Also documents relevant parts of the code for better understandability.Depends on #1574.