Enable scalafix on scala 3 #1227
Conversation
mlachkar
force-pushed
the
scalafix
branch
3 times, most recently
from
1b8f913 to
fb1d5ca
Compare
There was a problem hiding this comment.
I'm sorry for the long turnaround time, @mlachkar! Thanks for creating this pull request 🙂
This LGTM overall, but the build reorganization makes it a bit difficult to understand and I personally prefer using the top-level scope to define ThisBuild settings rather than wrapping them in inThisBuild. Looks like the project changes also caused CI errors.
Do you mind reverting that part and leave only the Scala 3 enabling? Thanks again!
.github/workflows/ci.yml
Outdated
| if: startsWith(matrix.scala, '2') | ||
| run: sbt "++${{ matrix.scala-version }} scalafixCheckAll" | ||
| - name: Check formatting and Scalafix | ||
| run: sbt "++${{ matrix.scala-version }}" scalafmtCheckAll scalafmtSbtCheck scalafixCheckAll |
There was a problem hiding this comment.
The difference in quotes is subtle, but significant. Here we actually want both scalafmtCheckAll and scalafixCheckAll in the same command as the version change - see my explanation about the differences between them in #1188. Can you please change this to either:
sbt "++${{ matrix.scala-version }} scalafmtCheckAll scalafixCheckAll" scalafmtSbtChecksbt "++${{ matrix.scala-version }} scalafmtCheckAll" "++${{ matrix.scala-version }} scalafixCheckAll" scalafmtSbtCheck
(I don't know if the first version works as is, so please test before submitting)
There was a problem hiding this comment.
The second one works!
|
I kept the linting test and formatting test separated even if the second command runs correctly! |
|
By the way, pureconfig is one of my favourite libraries! Thanks for your work! |
This pull request enable scalafix on Scala3.
I have also organised a little the build, I can remove this from my change.
Thanks!