Reduce several check tasks down to one #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit consolidates two tasks which check for a service to be available into one, and provides a convenience function wrapper for using that task so that the high-level plans are easier to read. Right now every use of the check just waits until the service is running, so the implementation puts the wait logic in the task itself. In the event a future need to actually return true/false if the service is running or not, it will be easy to refactor into a single "service_status" task instead, and put the wait logic into the convenience function wrapper for today's "wait until" uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit consolidates two tasks which check for a service to be
available into one, and provides a convenience function wrapper for
using that task so that the high-level plans are easier to read.
Right now every use of the check just waits until the service is
running, so the implementation puts the wait logic in the task itself.
In the event a future need to actually return true/false if the service
is running or not, it will be easy to refactor into a single
"service_status" task instead, and put the wait logic into the
convenience function wrapper for today's "wait until" uses.