Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-39224) Adding random console password for forked pr workflow #491

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ragingra
Copy link
Member

@ragingra ragingra commented Sep 5, 2024

Summary

CI jobs triggered from forked branches aren't able to access secrets. In this case we are using a randomised password.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024

CLA assistant check
All committers have signed the CLA.

@ragingra ragingra force-pushed the PE-39224 branch 2 times, most recently from 121c463 to e894d4c Compare September 5, 2024 17:00
CI jobs triggered from forked branches aren't able to access secrets.
In this case we are using a randomised password.
@ragingra ragingra marked this pull request as ready for review September 6, 2024 08:45
@ragingra ragingra requested review from a team as code owners September 6, 2024 08:45
@CoMfUcIoS CoMfUcIoS merged commit 9b0d70d into puppetlabs:main Sep 6, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants