(PE-37233-35) Official support of Add compiler plan #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoMfUcIoS
force-pushed
the
add_compiler_supported
branch
2 times, most recently
from
766cbe0 to
f7e007f
Compare
bastelfreak
reviewed
Sep 3, 2024
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| image: | ||
| description: 'GCP image for test cluster' |
There was a problem hiding this comment.
The quoting changes are quite confusing and make the diffs huge. I already mentioned that in another PR when single quotes we converted to double quotes, but only in some files. Is the change here to no quotes really required?
There was a problem hiding this comment.
Hey @bastelfreak, we are in the process to convert all the action YAML files to use the same formatting. So take this as the current format. There will be another pr to convert all other files to the same format.
Updated add_compiler spec to check compiler has been added and puppet run before running add compiler Added test matrix for add compiler
…oup_letter optional (#468) * (PE-38814) add_compiler - Making primary_postgresql_host and avail_group_letter optional primary_postgresql_host, if not provided will be determined through get_peadm_config avail_group_letter, is defaulting to A * Updating spec tests for add compiler Removing optional from avail_group_letter as not required with enum default value * Updating reference.md * Fixing linting issues --------- Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
* PE-37235 Verify and update documentation on add_compiler if needed and its experimental status * @cathal41 PE-37235 Verify and update documentation on add_compiler - wording updates * Update plans/add_compiler.pp Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> * Update documentation/add_compiler.md Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> * Update documentation/add_compiler.md Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> * Update documentation/add_compiler.md Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> * Update documentation/add_compiler.md Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> * Update documentation/add_compiler.md Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> * Updating add compiler docs to show optional params * Updating docs with text corrections --------- Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com> Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
- Removed unnecessary quotes around strings in YAML files. - Consolidated list items to single-line format where applicable. - Ensured consistent naming conventions for job steps. - Improved readability by removing extra blank lines.
- Added `console_password` parameter to the `test-add-compiler-matrix.yml` and `test-add-compiler.yaml` workflows. - This ensures the console password is passed correctly during the workflow execution.
- Remove centos-7 from the image matrix in test-add-compiler-matrix.yml - Retain only almalinux-cloud/almalinux-8 in the image matrix
Added the --stream option to the bolt plan run command in the test-add-compiler GitHub workflow. This change ensures that the output is streamed in real-time.
CoMfUcIoS
force-pushed
the
add_compiler_supported
branch
from
cd5794f to
3d0ed7e
Compare
….yml Updated the compiler versions in the test-add-compiler-matrix.yml GitHub workflow from 2021.7.7 and 2023.6.0 to 2021.7.9 and 2023.8.0.
ragingra
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding official support of compiler plan.
Checklist
Changes include test coverage?
Have you updated the documentation?