Fail with guidance if peadm::util::retrieve_and_upload is used on PE XL with the PCP transport #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates
peadm::util::retrieve_and_upload
to fail if the PCP transport is in use. When PCP is in use, file uploads are done via thebolt_shim::upload
task, which essentially reads the file into memory, encodes it, and then ships it over Orchestrator as an argument to thebolt_shim::upload
task.This method of file transfer is utterly inadequate for shipping files as large as the PE installer.
Additionally, the
fail_on_transport()
function is enhanced to accept an optional error message and existing usages offail_on_transport()
are updated with descriptive messages that explain why PCP is unavailable and how to work around it.Unit tests for
fail_on_transport()
are also fully implemented.