Sync FIPS detection with the PE installer #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `peadm` used the `fips-mode-setup --is-enabled` command to detect whether FIPS mode was enabled. Unfortunately, this command does not produce a meaningful exit code. It exits with success on RHEL 8 where the `--is-enabled` flag is invalid: ``` $ fips-mode-setup --is-enabled Check, enable, or disable the system FIPS mode. usage: /usr/bin/fips-mode-setup --enable|--disable [--no-bootcfg] usage: /usr/bin/fips-mode-setup --check $ echo $? 0 ``` And exits with success when FIPS mode is disabled: ``` $ fips-mode-setup --check Installation of FIPS modules is not completed. FIPS mode is disabled. $ echo $? 0 ``` The end result is that if the `crypto-policies-scripts` package happens to be installed on a RHEL node, `peadm` will assume the node is in FIPS mode and download the wrong PE installer package. This commit updates `peadm` to use the same method for detecting FIPS as the PE installer: `cat /proc/sys/crypto/fips_enabled`
Sharpie
force-pushed
the
use-procfs-to-detect-fips
branch
from
66ed667 to
8376f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
peadmused thefips-mode-setup --is-enabledcommand to detect whether FIPS mode was enabled. Unfortunately, this command does not produce a meaningful exit code. It exits with success on RHEL 8 where the--is-enabledflag is invalid:And exits with success when FIPS mode is disabled:
The end result is that if the
crypto-policies-scriptspackage happens to be installed on a RHEL node,peadmwill assume the node is in FIPS mode and download the wrong PE installer package.This commit updates
peadmto use the same method for detectingFIPS as the PE installer:
cat /proc/sys/crypto/fips_enabled