Allow compilers and replicas to merge csr_attributes. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bill Wilcox seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
reidmv
suggested changes
Mar 3, 2022
plans/subplans/install.pp
Outdated
| @@ -324,23 +324,28 @@ | |||
| ] | |||
|
|
|||
| $role_and_group = | |||
There was a problem hiding this comment.
Change request:
If we're switching to csr_attributes.yaml pre-population for all servers, let's strip it out of this block entirely (remove $role_and_group and anything that operates on it), and instead add the needed peadm::util::insert_csr_extension_requests task run to $csr_yaml_jobs on line 215.
There was a problem hiding this comment.
Added a commit with the requested change.
reidmv
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows compilers and replica servers being provisioned to respect the contents of an existing csr_attributes.yaml file.