Improve handling of unsuitable LANG settings #236
Conversation
If Ruby starts without a LANG env var, it will assume locale "C". This is a non-UTF-8 locale, and usually not the system default. If commands print UTF-8 characters, Ruby will fail to correctly parse them if it wasn't started with a valid locale. The main scenario we want to account for is when a privilege escalation command such as sudo or powerbroker has elevated a shell, but stripped all environment variables out of it. If that happened, we want to try and set the default system locale, which should be in /etc/default/locale.
Bolt tasks are very difficult to debug because they hide stderr output. This commit adds a task helper which should reveal that output.
|
Aaaaaand no failures occurred now that failures would be revealed more fully when they happen. Classic. This would seem to indicate that the failures were transient though, whatever they were. |
|
This is the test suite job that failed: And this is the manual re-run of that job with the new commit that passed: The point of the new bash task_helper.sh script was supposed to be to return stderr and in so doing reveal what actually went wrong, but since nothing went wrong on the second run it seems like the failure might have been a transient. I'm going to trigger the full suite again and if it passes, will merge the PR. It's not bad to have the task_helper for the future. |
reidmv
changed the title
If Ruby starts without a LANG env var, it will assume locale "C". This
is a non-UTF-8 locale, and usually not the system default. If commands
print UTF-8 characters, Ruby will fail to correctly parse them if it
wasn't started with a valid locale.
The main scenario we want to account for is when a privilege escalation
command such as sudo or powerbroker has elevated a shell, but stripped
all environment variables out of it. If that happened, we want to try
and set the default system locale, which should be in
/etc/default/locale.