Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global rename of primary/replica and postgresql parameters #161

Merged
merged 6 commits into from
Jun 17, 2021
Merged

Global rename of primary/replica and postgresql parameters #161

merged 6 commits into from
Jun 17, 2021

Conversation

timidri
Copy link
Contributor

@timidri timidri commented Jun 14, 2021

Global rename of:

  • primary_repica_host -> replica_host
  • puppetdb_database_host -> primary_postgresql_host
  • puppetdb_database_replica_host -> replica_postgresql_host

Also local target variables are renamed accordingly.

@timidri timidri requested review from davidsandilands and removed request for davidsandilands June 14, 2021 11:50
@timidri timidri force-pushed the SOLARCH-486-change-puppetdb_database_host-parameter-s-to-pe_p branch from 251515f to b3aaa75 Compare June 15, 2021 12:46
@timidri timidri marked this pull request as ready for review June 15, 2021 12:48
@timidri timidri requested a review from a team as a code owner June 15, 2021 12:48
@timidri timidri requested a review from reidmv June 15, 2021 12:49
davidsandilands
davidsandilands reviewed Jun 15, 2021
View reviewed changes
plans/install.pp Outdated Show resolved Hide resolved
davidsandilands
davidsandilands reviewed Jun 15, 2021
View reviewed changes
plans/upgrade.pp Outdated Show resolved Hide resolved
davidsandilands
davidsandilands reviewed Jun 15, 2021
View reviewed changes
plans/upgrade.pp Outdated Show resolved Hide resolved
davidsandilands
davidsandilands reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@davidsandilands davidsandilands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just put a few notes on indentation but overall looks good to me

@timidri timidri requested review from reidmv and removed request for reidmv June 15, 2021 14:58
reidmv
reidmv reviewed Jun 17, 2021
View reviewed changes
plans/action/install.pp Outdated Show resolved Hide resolved
@reidmv reidmv force-pushed the SOLARCH-486-change-puppetdb_database_host-parameter-s-to-pe_p branch from f280795 to b91b9aa Compare June 17, 2021 00:11
@reidmv reidmv requested review from reidmv and removed request for reidmv June 17, 2021 00:12
@reidmv reidmv force-pushed the SOLARCH-486-change-puppetdb_database_host-parameter-s-to-pe_p branch from b91b9aa to 83cb6c3 Compare June 17, 2021 00:16
@reidmv reidmv removed their request for review June 17, 2021 00:16
@reidmv
Fix spec test
4a5a688 
This fixes the spec test, which incidentally broke when Dimitri
accidentally fixed a missing step in the install plan
@reidmv reidmv self-requested a review June 17, 2021 00:22
@reidmv reidmv merged commit 0b8af72 into puppetlabs:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsandilands davidsandilands davidsandilands left review comments

@reidmv reidmv Awaiting requested review from reidmv

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timidri @reidmv @davidsandilands