Add add_compiler plan #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidmv
suggested changes
Jun 2, 2021
There was a problem hiding this comment.
Doing a "30 percent feedback" review.
Parameter names:
We should align with the naming conventions for parameters established in other peadm plans.
$compiler_fqdn=>$compiler_host$primary_server_fqdn=>$primary_host$postgresql_server_fqdn=>$puppetdb_database_host- Add:
$puppetdb_database_replica_host– if this target is provided, perform the same operation(s) on it as on puppetdb_database_host
Looking good overall. Coming along nicely. 👍
timidri
force-pushed
the
SOLARCH-463-peadm-plan-add-or-replace-compiler
branch
from
ae8f6f2 to
89c6414
Compare
|
This PR is ready for review now @reidmv |
timidri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: add_compiler plan