Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer exit handling #152

Merged
merged 6 commits into from
Apr 2, 2021

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Apr 2, 2021

This PR cleans up exit code handling when dealing with the fact that puppet-enterprise-installer exits 1 during extra-large installs, due to PuppetDB not being able to start yet.

reidmv added 2 commits April 1, 2021 16:31
Previously, the pe_install task would ignore any erroneous exit codes
emitted by the pe installer. This caused user confusion because actual
failures to install resulted in strange errors later in the plan. This
commit improves the user experience by ensuring some basic smoke tests
pass, or else actually failing at this step.
@reidmv reidmv requested a review from a team as a code owner April 2, 2021 00:56
It can be done at the same time other agents are installing
@reidmv reidmv force-pushed the fix-installer-exit-handling branch 2 times, most recently from 35fa246 to 45418d6 Compare April 2, 2021 04:13
Copy link
Member

@ody ody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with code, improvements seem to work, ran through a xlarge install w/o replica, 3 compilers, and 3 agents

reidmv added 3 commits April 2, 2021 14:01
When signing CSRs, it is common that the CSR will have been submitted
just prior. Previously, plans which did both would have to pause after
submitting the CSR to ensure there was time for the server to have fully
processed it before running the sign task, in order to avoid any chance
of ready-to-sign timing problems.

This commit makes the sign_csr task itself attempt to sign up to six
times, waiting one second between attempts, in order to avoid needing to
do that in the plan.
The default PE version, the listed supported Bolt version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants