Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-130 Fix overwrite of user config data #132

Merged
merged 1 commit into from
Nov 2, 2020
Merged

GH-130 Fix overwrite of user config data #132

merged 1 commit into from
Nov 2, 2020

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Nov 2, 2020

Users may have their own config data specified for the PE Master group.
This commit ensures that when peadm enforces node group configuration
including config data on the PE Master group, it merges required config
into existing user data to avoid configuration loss.

Fixes #130

@reidmv reidmv requested a review from a team as a code owner November 2, 2020 19:15
@puppet-community-rangefinder
Copy link

peadm::merge_ng_config_data is a function

that may have no external impact to Forge modules.

peadm::setup::node_manager is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@reidmv
GH-130 Fix overwrite of user config data
01955a1 
Users may have their own config data specified for the PE Master group.
This commit ensures that when peadm enforces node group configuration
including config data on the PE Master group, it merges required config
into existing user data to avoid configuration loss.
@reidmv reidmv merged commit 563eb2e into main Nov 2, 2020
@reidmv reidmv deleted the GH-130 branch November 2, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade deletes class parameters from PE Master (other groups too?)
1 participant
@reidmv