Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdk update 3.2.0 #1173

Merged
merged 6 commits into from
Jun 14, 2024
Merged

pdk update 3.2.0 #1173

merged 6 commits into from
Jun 14, 2024

Conversation

kenyon
Copy link

@kenyon kenyon commented Apr 9, 2024

Includes #1172.

kenyon added 2 commits April 8, 2024 22:56
The $auth_conf_tmp line should be multiple lines for readability and
easier to read diffs when changes occur.

Double-indented blocks look wrong. Placing the opening bracket on its
own line fixes this.
@kenyon kenyon requested review from bastelfreak, smortex and a team as code owners April 9, 2024 06:14
@kenyon kenyon marked this pull request as draft April 9, 2024 06:22
@kenyon kenyon force-pushed the pdk-update-3.0.1 branch from 3c2e542 to 462b31d Compare April 9, 2024 06:24
kenyon added 2 commits April 8, 2024 23:47
params.pp and create_resources() are obsolete.

This module was converted to non-params.pp style puppetlabs#667, but was
reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the
preferred styles these days.
@kenyon kenyon force-pushed the pdk-update-3.0.1 branch from 462b31d to ed42887 Compare April 9, 2024 06:50
@kenyon kenyon marked this pull request as ready for review April 9, 2024 07:07
@@ -5,7 +5,7 @@ require:
AllCops:
NewCops: enable
DisplayCopNames: true
TargetRubyVersion: '2.7'
TargetRubyVersion: '2.6'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this is downgraded

bastelfreak
bastelfreak previously approved these changes Apr 9, 2024
@kenyon kenyon force-pushed the pdk-update-3.0.1 branch from ed42887 to 5415131 Compare May 18, 2024 22:51
@kenyon kenyon changed the title pdk update 3.0.1 pdk update 3.2.0 May 18, 2024
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ramesh7 Ramesh7 merged commit abbbe6b into puppetlabs:main Jun 14, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants