Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSpec/DescribedClass. #344

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix RSpec/DescribedClass. #344

merged 1 commit into from
Mar 4, 2024

Conversation

gavindidrichsen
Copy link
Contributor

This error appears something like RSpec/DescribedClass: Use `described_class` instead of `PDK::Util`.. This rule is triggered when the class under test is referenced directly instead of using described_class.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

This error appears something like ``RSpec/DescribedClass: Use `described_class` instead of `PDK::Util`.``.  This rule is triggered when the class under test is referenced directly instead of using `described_class`.

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
@gavindidrichsen gavindidrichsen added the maintenance Maintenance (PDK sync and other maintaining commits) label Mar 1, 2024
@gavindidrichsen gavindidrichsen marked this pull request as ready for review March 1, 2024 20:43
@gavindidrichsen gavindidrichsen requested review from a team as code owners March 1, 2024 20:43
@jordanbreen28 jordanbreen28 merged commit e4a8fc8 into main Mar 4, 2024
9 of 10 checks passed
@jordanbreen28 jordanbreen28 deleted the maint_fix_rubocop branch March 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (PDK sync and other maintaining commits)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants