Implement page.$eval #638

aslushnikov · 2017-08-31T18:53:13Z

This patch:

implements page.$eval and frame.$eval
drops elementHandle.attribute() method in favor of the page.$eval

References #625

This patch: - implements page.$eval and frame.$eval - drops elementHandle.attribute() method in favor of the page.$eval References puppeteer#625

JoelEinbinder · 2017-08-31T18:55:49Z

Can this take ...args like the old page.$?

vsemozhetbyt · 2017-08-31T19:00:03Z

docs/api.md

+
+If `pageFunction` returns a [Promise], then `page.$eval` would wait for the promise to resolve and return it's value.
+
+Shortcut for [page.mainFrame().$eval(selector, pageFunction)](#frameevalselector-pageFunction).


#frameevalselector-pageFunction -> #frameevalselector-pagefunction (F => f) ?

paulirish · 2017-08-31T19:00:59Z

Could use an example.. maybe one of these?

const searchValue = await page.$eval('#search', el => el.value);

const preloadHref = await page.$eval('link[rel=preload]', el => el.href);

const html = await page.$eval('.main-container', e => e.outerHTML);

ebidel · 2017-08-31T19:02:42Z

docs/api.md

+
+If `pageFunction` returns a [Promise], then `page.$eval` would wait for the promise to resolve and return it's value.
+
+Shortcut for [page.mainFrame().$eval(selector, pageFunction)](#frameevalselector-pageFunction).


Maybe add some useful examples:

const isHidden = await page.$eval('.hidden', el => el.hasAttribute('hidden')); const val = await page.$eval('input[type="text"]', el => el.value); const id = await page.$eval('div.item', el => el.dataset.id);

aslushnikov · 2017-08-31T19:07:07Z

@JoelEinbinder sure. Do you have an example where arguments would be useful?

vsemozhetbyt · 2017-08-31T19:23:04Z

docs/api.md

@@ -1056,6 +1076,23 @@ The method queries frame for the selector. If there's no such element within the

 The method runs `document.querySelectorAll` within the frame. If no elements match the selector, the return value resolve to `[]`.

+#### frame.$eval(selector, pageFunction)


+ , ...args ?

vsemozhetbyt · 2017-08-31T19:25:25Z

docs/api.md

@@ -31,6 +31,7 @@
    + [event: 'response'](#event-response)
    + [page.$(selector)](#pageselector)
    + [page.$$(selector)](#pageselector)
+    + [page.$eval(selector, pageFunction)](#pageevalselector-pagefunction)


+ , ...args ?

#pageevalselector-pagefunction-args ?

vsemozhetbyt · 2017-08-31T19:25:38Z

docs/api.md

@@ -94,6 +95,7 @@
  * [class: Frame](#class-frame)
    + [frame.$(selector)](#frameselector)
    + [frame.$$(selector)](#frameselector)
+    + [frame.$eval(selector, pageFunction)](#frameevalselector-pagefunction)


+ , ...args ?

#frameevalselector-pagefunction-args ?

JoelEinbinder · 2017-08-31T20:49:37Z

lib/FrameManager.js

@@ -197,6 +197,21 @@ class Frame {

  /**
   * @param {string} selector
+   * @param {function()|string} pageFunction
+   * @param {!Array<*>} args
+   * @return {!Promise<?ElementHandle>}


This does not return an element handle. It returns !Promise<*>

JoelEinbinder · 2017-08-31T20:49:46Z

lib/Page.js

@@ -148,6 +148,16 @@ class Page extends EventEmitter {

  /**
   * @param {string} selector
+   * @param {function()|string} pageFunction
+   * @param {!Array<*>} args
+   * @return {!Promise<?ElementHandle>}


Same as above.

JoelEinbinder · 2017-08-31T21:52:10Z

docs/api.md

@@ -323,6 +324,25 @@ The method runs `document.querySelectorAll` within the page. If no elements matc

 Shortcut for [page.mainFrame().$$(selector)](#frameselector-1).

+#### page.$eval(selector, pageFunction[, ...args])
+- `selector` <[string]> Selector to query page for


Implement page.$eval

db495c1

This patch: - implements page.$eval and frame.$eval - drops elementHandle.attribute() method in favor of the page.$eval References puppeteer#625

aslushnikov requested a review from JoelEinbinder August 31, 2017 18:53

vsemozhetbyt reviewed Aug 31, 2017

View reviewed changes

ebidel reviewed Aug 31, 2017

View reviewed changes

vsemozhetbyt mentioned this pull request Aug 31, 2017

elementHandle.attribute doesn't work #636

Closed

add args

742c0ea

vsemozhetbyt reviewed Aug 31, 2017

View reviewed changes

fix issues

c2a65ce

JoelEinbinder reviewed Aug 31, 2017

View reviewed changes

fix jsdoc to align with page.evaluate

4b93f5e

JoelEinbinder reviewed Aug 31, 2017

View reviewed changes

JoelEinbinder approved these changes Aug 31, 2017

View reviewed changes

Update api.md

d8a9af7

aslushnikov merged commit 62ececb into puppeteer:master Aug 31, 2017

aslushnikov deleted the deval branch October 10, 2017 00:20

vsemozhetbyt mentioned this pull request Oct 15, 2017

Collect element attributes from selector #628

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement page.$eval #638

Implement page.$eval #638

aslushnikov commented Aug 31, 2017

JoelEinbinder commented Aug 31, 2017

vsemozhetbyt Aug 31, 2017

aslushnikov Aug 31, 2017

paulirish commented Aug 31, 2017

ebidel Aug 31, 2017 •

edited

Loading

aslushnikov commented Aug 31, 2017

vsemozhetbyt Aug 31, 2017 •

edited

Loading

vsemozhetbyt Aug 31, 2017

vsemozhetbyt Aug 31, 2017 •

edited

Loading

JoelEinbinder Aug 31, 2017

aslushnikov Aug 31, 2017

JoelEinbinder Aug 31, 2017

JoelEinbinder Aug 31, 2017


		If `pageFunction` returns a [Promise], then `page.$eval` would wait for the promise to resolve and return it's value.

		Shortcut for [page.mainFrame().$eval(selector, pageFunction)](#frameevalselector-pageFunction).

		@@ -1056,6 +1076,23 @@ The method queries frame for the selector. If there's no such element within the

		The method runs `document.querySelectorAll` within the frame. If no elements match the selector, the return value resolve to `[]`.

		#### frame.$eval(selector, pageFunction)

Implement page.$eval #638

Implement page.$eval #638

Conversation

aslushnikov commented Aug 31, 2017

JoelEinbinder commented Aug 31, 2017

vsemozhetbyt Aug 31, 2017

Choose a reason for hiding this comment

aslushnikov Aug 31, 2017

Choose a reason for hiding this comment

paulirish commented Aug 31, 2017

ebidel Aug 31, 2017 • edited Loading

Choose a reason for hiding this comment

aslushnikov commented Aug 31, 2017

vsemozhetbyt Aug 31, 2017 • edited Loading

Choose a reason for hiding this comment

vsemozhetbyt Aug 31, 2017

Choose a reason for hiding this comment

vsemozhetbyt Aug 31, 2017 • edited Loading

Choose a reason for hiding this comment

JoelEinbinder Aug 31, 2017

Choose a reason for hiding this comment

aslushnikov Aug 31, 2017

Choose a reason for hiding this comment

JoelEinbinder Aug 31, 2017

Choose a reason for hiding this comment

JoelEinbinder Aug 31, 2017

Choose a reason for hiding this comment

ebidel Aug 31, 2017 •

edited

Loading

vsemozhetbyt Aug 31, 2017 •

edited

Loading

vsemozhetbyt Aug 31, 2017 •

edited

Loading