Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use objects instead of maps to describe headers #567

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Use objects instead of maps to describe headers #567

merged 1 commit into from
Aug 28, 2017

Conversation

aslushnikov
Copy link
Contributor

This patch:

  • switches to objects instead of maps for headers (in Request, Response and
    page.setExtraHTTPHeaders)
  • converts all header names to lower case

Fixes #547, fixes #509

@aslushnikov aslushnikov mentioned this pull request Aug 27, 2017
Closed
@aslushnikov aslushnikov merged commit 66912a7 into puppeteer:master Aug 28, 2017
@aslushnikov aslushnikov deleted the object-headers branch October 10, 2017 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aslushnikov @JoelEinbinder