Test node6 on travis #551
Test node6 on travis #551
Conversation
utils/node6-transform/index.js
Outdated
| fs.readdirSync(source).forEach(file => { | ||
| const curSource = path.join(source, file); | ||
| if (fs.lstatSync(curSource).isDirectory()) { | ||
| copyFolder(curSource, path.join(target, path.basename(curSource))); |
There was a problem hiding this comment.
isn't path.basename(curSource) === file?
utils/node6-transform/index.js
Outdated
| const output = transformAsyncFunctions(content); | ||
| fs.writeFileSync(path.resolve(outPath, filePath), output); | ||
| }); | ||
| function copyFolder(source, target, root) { |
utils/node6-transform/index.js
Outdated
|
|
||
| fs.readdirSync(source).forEach(file => { | ||
| const curSource = path.join(source, file); |
There was a problem hiding this comment.
Let's do the path-joining magic in the very beginning so that it's easier to follow what's going on.
const from = path.join(source, file);
const to = path.join(target, file);
...
utils/node6-transform/index.js
Outdated
| const curSource = path.join(source, file); | ||
| if (fs.lstatSync(curSource).isDirectory()) { | ||
| copyFolder(curSource, path.join(target, path.basename(curSource))); | ||
| } else { |
There was a problem hiding this comment.
let's check for file explicitly. It would not be nice to write over a symlink.
There was a problem hiding this comment.
I don't know what you mean by this one.
There was a problem hiding this comment.
I mean:
if (fs.lstatSync(curSource).isDirectory()) {
...
} else if (fs.lstatSync(curSource).isFile()) {
...
}
utils/node6-transform/index.js
Outdated
| } else { | ||
| let text = fs.readFileSync(curSource); | ||
| if (curSource.endsWith('.js')) | ||
| text = transformAsyncFunctions(text.toString()).replace(/require\('\.\.\/lib\//g, `require('../node6/`); |
There was a problem hiding this comment.
doesn't copying everything into a node6/ work? this would spare you from this replace.
I.e.:
removeSync('node6');
copyFolder('lib', 'node6/lib');
copyFolder('test', 'node6/test');
copyFile('index.js', 'node6/index.js');There was a problem hiding this comment.
It gets really tricky because we load some utils from lib, and some utils are hard to convert. There are also paths for things like package.json and .local-chromium which get confusing.
No description provided.