Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute(key) and property(key) methods to ElementHandle #543

Merged
merged 7 commits into from
Aug 29, 2017

Conversation

batiste
Copy link

@batiste batiste commented Aug 25, 2017

Related to my issue here #438

I implemented those methods. Those are just simple shortcuts but I think they might be useful to write tests.

    it('should return attribute', SX(async function() {
      await page.setContent('<section id="testAttribute">43543</section>');
      const element = await page.$('section');
      expect(element).toBeTruthy();
      expect(await element.attribute('id')).toBe('testAttribute');
    }));

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@batiste
Copy link
Author

batiste commented Aug 25, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@aslushnikov
Copy link
Contributor

Nicee, thank you for the PR!

We're currently working on #382, and the feature will add the properties() method that would return object handles.

Given this, let's scope this PR only to the attribute() method.

@batiste
Copy link
Author

batiste commented Aug 28, 2017

@aslushnikov very well. I removed the property method.

@aslushnikov
Copy link
Contributor

@batiste please run the npm run doc command to update table-of-contents in api.md and satisfy documentation linter.

@batiste
Copy link
Author

batiste commented Aug 29, 2017

@aslushnikov done!

@aslushnikov aslushnikov merged commit 77600c6 into puppeteer:master Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants