-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute(key) and property(key) methods to ElementHandle #543
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Nicee, thank you for the PR! We're currently working on #382, and the feature will add the Given this, let's scope this PR only to the |
@aslushnikov very well. I removed the property method. |
@batiste please run the |
@aslushnikov done! |
Related to my issue here #438
I implemented those methods. Those are just simple shortcuts but I think they might be useful to write tests.