Kill PhantomShim. #533
Merged
Kill PhantomShim. #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch kills PhantomShim, a lightweight layer that helped to bootstrap Puppeteer API. At this point, PhantomShim: - passes 139 phantomJS tests - fails 13 tests - lacks capabilities to run 26 The failings and unsupported tests don't have any value for Puppeteer API, so it doesn't make sense to maintain PhantomShim any longer.
package.json
Outdated
| @@ -19,7 +18,6 @@ | |||
| "coverage": "COVERAGE=true npm run unit", | |||
| "node6": "node utils/node6-transform/index.js", | |||
| "test-node6": "jasmine utils/node6-transform/test/test.js", | |||
| "build": "npm run node6", | |||
There was a problem hiding this comment.
I think this was unintentional removal.
There was a problem hiding this comment.
That's a drive-by. Do we need it?
There was a problem hiding this comment.
I wanted to future proof, in case we have more build steps.
|
Github lags when looking through the files changed, but I think you missed the entires in |
|
Thanks, cleaned up |
JoelEinbinder
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch kills PhantomShim, a lightweight layer that helped to
bootstrap Puppeteer API.
At this point, PhantomShim:
The failings and unsupported tests don't have any value for Puppeteer
API, so it doesn't make sense to maintain PhantomShim any longer.