Implement page.$$ method #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/api.md
Outdated
| - `selector` <[string]> Selector to query page for | ||
| - returns: <[Promise]<[Array]<[ElementHandle]>>> Promise which resolves to ElementHandles pointing to the page elements. | ||
|
|
||
| The method queries page for all elements matching selector. If there are no such elements within the page, the method will resolve to `[]`. |
There was a problem hiding this comment.
Let's have the description here as above.
test/test.js
Outdated
| it('should query existing elements', SX(async function() { | ||
| await page.setContent('<div>A</div><br/><div>B</div>'); | ||
| let elements = await page.$$('div'); | ||
| expect(elements.length).toBe(2); |
There was a problem hiding this comment.
Let's dump the content, so we at least know that it is creating ElementHandles.
expect(await Promise.all(elements.map(e => e.evaluate(g => g.textContent)))).toEqual(['A','B'])
JoelEinbinder
approved these changes
Aug 22, 2017
| @@ -27,6 +27,7 @@ | |||
| + [event: 'requestfinished'](#event-requestfinished) | |||
| + [event: 'response'](#event-response) | |||
| + [page.$(selector)](#pageselector) | |||
| + [page.$$(selector)](#pageselector) | |||
There was a problem hiding this comment.
Should be #pageselector-1
There was a problem hiding this comment.
Unfortunately, this is a bug in the toc-generator.
| @@ -85,6 +86,7 @@ | |||
| + [dialog.type](#dialogtype) | |||
| * [class: Frame](#class-frame) | |||
| + [frame.$(selector)](#frameselector) | |||
| + [frame.$$(selector)](#frameselector) | |||
There was a problem hiding this comment.
Should be #frameselector-1
docs/api.md
Outdated
|
|
||
| The method runs `document.querySelectorAll` within the page. If no elements match the selector, the return value resolve to `[]`. | ||
|
|
||
| Shortcut for [page.mainFrame().$$(selector)](#frameselector). |
There was a problem hiding this comment.
Should be #frameselector-1
docs/api.md
Outdated
| @@ -978,6 +988,11 @@ puppeteer.launch().then(async browser => { | |||
|
|
|||
| The method queries page for the selector. If there's no such element within the page, the method will resolve to `null`. | |||
|
|
|||
| #### frame.$$(selector) | |||
| - `selector` <[string]> Selector to query page for | |||
| - returns: <[Promise]<[Array]<[ElementHandle]>>> Promise which resolves to ElementHandles pointing to the page elements. | |||
There was a problem hiding this comment.
I wonder, maybe all the page instances should be replaced by frame in frame API descriptions when appropriate?
This patch implements page.$$ which runs document.querySelectorAll in page and returns results as an array of ElementHandle instances. Fixes puppeteer#384.
aslushnikov
force-pushed
the
query-selector-all
branch
from
d3d1e48 to
54daeb3
Compare
kevin940726
reviewed
Aug 23, 2017
| const promises = elements.map(element => element.evaluate(e => e.textContent)); | ||
| expect(await Promise.all(promises)).toEqual(['A', 'B']); | ||
| })); | ||
| it('should return ampty array if nothing is found', SX(async function() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements page.$$ that runs document.querySelectorAll
in page and returns results as an array of ElementHandle instances.
Fixes #384.