docs: add table-of-contents to troubleshooting #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drive-by: teach our table-of-contents generator to ignore comments inside fenced blocks and to de-linkify titles.
| @@ -156,6 +156,42 @@ describe('runCommands', function() { | |||
| #### page.$ | |||
| #### page.$$`); | |||
| }); | |||
| it('should work with code blocks', () => { | |||
| const source = new Source('doc.md', `<!-- gen:toc -->XXX<!-- gen:stop --> | |||
| ### class: page | |||
There was a problem hiding this comment.
nit: remove tabs here and below.
There was a problem hiding this comment.
that's aligned with other tests :-) if you really want, I'll follow up for them all!
JoelEinbinder
approved these changes
Apr 3, 2019
kiku-jw
pushed a commit
to kiku-jw/puppeteer
that referenced
this pull request
Apr 6, 2019
Drive-by: teach our table-of-contents generator to ignore comments inside fenced blocks and to de-linkify titles.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by: teach our table-of-contents generator to ignore comments
inside fenced blocks and to de-linkify titles.