feat(launcher): add browserUrl option to puppeteer.connect #3558
Conversation
lib/Puppeteer.js
Outdated
| @@ -37,7 +37,7 @@ module.exports = class { | |||
| } | |||
|
|
|||
| /** | |||
| * @param {!(Launcher.BrowserOptions & {browserWSEndpoint: string, transport?: !Puppeteer.ConnectionTransport})} options | |||
| * @param {!(Launcher.BrowserOptions & {browserWSEndpoint: string, browserUrl: string, transport?: !Puppeteer.ConnectionTransport})} options | |||
There was a problem hiding this comment.
browserUrl?:
The question mark makes it optional.
There was a problem hiding this comment.
Should we make both browserWSEndpoint and browserUrl optional then? You should pass one or another, but not both.
lib/Launcher.js
Outdated
| const {webSocketDebuggerUrl} = JSON.parse(data); | ||
| resolve(webSocketDebuggerUrl); | ||
| } catch (e) { | ||
| onGetWsEndpointError(e); |
There was a problem hiding this comment.
I don't think we need special error forwarding here.
There was a problem hiding this comment.
This is to display the same user-friendly error message both in case of network failure and JSON parsing failure. Example:
Error: Failed to fetch browser webSocket url from http://127.0.0.1:21222/: SyntaxError: Unexpected token < in JSON at position 0
at onGetWsEndpointError (/Users/lf/Projects/puppeteer/lib/Launcher.js:413:12)
at onGetWsEndpointDone (/Users/lf/Projects/puppeteer/lib/Launcher.js:408:7)
at IncomingMessage.res.on (/Users/lf/Projects/puppeteer/lib/Launcher.js:426:25)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1064:12)
at _combinedTickCallback (internal/process/next_tick.js:139:11)
at process._tickCallback (internal/process/next_tick.js:181:9)
…ional, refactor function names in getWSEndpoint
|
Added docs, made |
| [ConnectionTransport]: ../lib/WebSocketTransport.js "ConnectionTransport" |
There was a problem hiding this comment.
a final new line was added at the end of this file, conforming with .editorconfig
Fixes #3537
I will add documentation if the code is ok.