fix(page): dispatch errors into page #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors thrown on the node side of the `page.exposeFunction` callback should be dispatched into the page. Fixes puppeteer#3549
aslushnikov
changed the title
lib/Page.js
Outdated
| } | ||
|
|
||
| function deliverError(name, seq, message, stack) { | ||
| let error = new Error(message); |
lib/Page.js
Outdated
| error = e; | ||
| } | ||
| let expression = null; | ||
| if (error) |
There was a problem hiding this comment.
Things can throw null. Instead of checking if there is an error, do the logic in the catch.
There was a problem hiding this comment.
Fair. Creepy, but fair.
| window[name]['callbacks'].delete(seq); | ||
| } | ||
|
|
||
| function deliverError(name, seq, message, stack) { |
JoelEinbinder
approved these changes
Nov 15, 2018
|
oh, we should probably pass the name as well. For TimeoutErrors |
satanninja
reviewed
Nov 20, 2018
| @@ -428,7 +428,7 @@ class Page extends EventEmitter { | |||
| } | |||
| const seq = (me['lastSeq'] || 0) + 1; | |||
| me['lastSeq'] = seq; | |||
| const promise = new Promise(fulfill => callbacks.set(seq, fulfill)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors thrown on the node side of the
page.exposeFunctioncallbackshould be dispatched into the page.
Fixes #3549