fix(page.evaluate): better function serialization #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/ExecutionContext.js
Outdated
| } catch (e1) { | ||
| // This means we have a function shorthand. Try another | ||
| // time prefixing 'function '. | ||
| functionText = 'function ' + functionText; |
There was a problem hiding this comment.
What about async static generators?
There was a problem hiding this comment.
async done; the rest is too exotic for now!
lib/ExecutionContext.js
Outdated
| @@ -94,8 +94,23 @@ class ExecutionContext { | |||
| if (typeof pageFunction !== 'function') | |||
| throw new Error('The following is not a function: ' + pageFunction); | |||
|
|
|||
| let functionText = pageFunction.toString(); | |||
| try { | |||
| eval(functionText); | |||
There was a problem hiding this comment.
I'd be worried about unintended side effects here. Consider: function functionText(){return 5}.
There was a problem hiding this comment.
good catch; switched to new Function instead
|
Can we also add a note about |
lib/ExecutionContext.js
Outdated
| try { | ||
| new Function('(' + functionText + ')'); | ||
| } catch (e1) { | ||
| // This means we have a function shorthand. Try another |
There was a problem hiding this comment.
Suggested change
| // This means we have a function shorthand. Try another | |
| // This means we might have a function shorthand. Try another |
JoelEinbinder
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1665