test: drop jasmine test runner #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test.js
Outdated
| const reporter = new Reporter(runner); | ||
|
|
||
| const {describe, xdescribe, fdescribe} = runner; | ||
| const {it, fit, xit} = runner; |
There was a problem hiding this comment.
we should probably have an eslint-disable here for the unused variable rule.
| const timeout = process.env.DEBUG_TEST || slowMo ? 0 : 10 * 1000; | ||
|
|
||
| const {TestRunner, Reporter, Matchers} = require('../utils/testrunner/'); | ||
| const runner = new TestRunner({timeout}); |
There was a problem hiding this comment.
The main benefit of the test runner is that it runs tests in parallel right? This patch looks fine, but I don't think we should land it until we are sure that the tests run correctly in parallel on the bots.
There was a problem hiding this comment.
Let's not run tests in parallel.
aslushnikov
force-pushed
the
new-testrunner
branch
2 times, most recently
from
2177e9a to
7607f50
Compare
JoelEinbinder
approved these changes
Dec 8, 2017
This patch drops jasmine test runner in favor of a home-grown test runner.
aslushnikov
force-pushed
the
new-testrunner
branch
from
7607f50 to
339e8f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a tiny test runner to run puppeteer tests.
The test runner is self-container and allows parallel test execution.
It will also allow us to split tests into multiple files if necessary.
Comparing to the jasmine, the testrunner supports parallel execution, properly
handles "unhandled promise rejection" event and signals.
Comparing to ava/jest, the testrunner doesn't run multiple node processes,
which makes it simpler but sufficient for our goals.