Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use numeric user ID in Dockerfile for pptruser #13272

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dulith-muthu
Copy link
Contributor

What kind of change does this PR introduce?
A bugfix for: #13270

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Use numeric user ID in Dockerfile to comply with Kubernetes PodSecurityPolicy

  • Replaced non-numeric username (pptruser) with numeric USER ID using PPTRUSER_UID environment variable.
  • Ensures compatibility with runAsNonRoot policy in Kubernetes.

Does this PR introduce a breaking change?
No

…ecurityPolicy

- Replaced non-numeric username (`pptruser`) with numeric `USER` ID using `PPTRUSER_UID` environment variable.
- Ensures compatibility with `runAsNonRoot` policy in Kubernetes.
@dulith-muthu dulith-muthu force-pushed the dulith/docker_numeric_user_id branch from b30afd9 to 4ce6887 Compare November 6, 2024 11:39
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrKoN OrKoN merged commit d40658f into puppeteer:main Nov 6, 2024
35 checks passed
@dulith-muthu dulith-muthu deleted the dulith/docker_numeric_user_id branch November 8, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants