-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update node-fetch package #7924
Conversation
Update node-fetch to version 2.6.7 to avoid a high vulnerability GHSA-r683-j2x4-v87g
Any idea of when the npm package will update? 👀 |
A maintainer have to release the projet to NPM. I'm not sure if I've the right to do that. |
We are stuck on an old version of Puppeteer - which is also affected by that tight pin to 2.6.1 - because of a bug, evidently in Chrome, that affects the use of There's a deep dive there, along with a straightforward fix for the issue: However, this ticket has not yet been seen by any Puppeteer devs. As this is actually a pretty severe issue when it's encountered, attention to this would be appreciated (and would allow those of us affected to properly upgrade Puppeteer to the more secure, current version). |
Can we also patch the other major versions?
In my use case, we are running the v93 version of chromium as it is available on latest alpine. |
13.1.2 has just been released https://github.com/puppeteer/puppeteer/releases/tag/v13.1.2 |
I don't think we support back-merges in Puppeteer as we don't keep branches for releases? Also, you should try to use the latest version of Chromium since there are probably security fixes included. cc @mathiasbynens |
Indeed, we don’t actively support older versions. Always use the latest possible version. (Perhaps we should more aggressively |
The issue is that latest chromium installation on latest alpine is v93: https://pkgs.alpinelinux.org/packages?name=chromium&branch=v3.15 so I'm not sure if I would call it "outdated" 😄. |
drealecs@ would it be an option for you to use npm-force-resolutions or similar to patch the vulnerable package? |
Yes, it would be an option but I think my use case is broader and it would only fix my project so it's not in the spirit of open-source collaboration. |
For that to work, we need to update the documentation, set up GitHub actions for releasing and testing from the branches and test all of those processes. Ideally, automate most of it. @mathiasbynens WDYT? I don't think we can handle it right now but maybe we can have it on a roadmap in near/mid future. |
Thanks for the update! Sounds like a longer timeline target for update than what I would need now but it would be good to have it, whenever there is time for it. Just leaving a note here for future developers encountering this:
|
Update node-fetch to version 2.6.7 to avoid a high vulnerability
Issue: #7921
GHSA-r683-j2x4-v87g