Feat: Expose HTTPRequest intercept resolution state and clarify docs #7796
Conversation
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
…/puppeteer into expose-intercept-resolution-2
|
@FdezRomero Please sign the CLA now that your name is in the commit history :) https://cla.developers.google.com/ |
|
Hello @remusao and @Kikobeats from ghostery/adblocker#2281 and microlinkhq/browserless#321 :) You are among the first to implement cooperative mode support, I would love to get your feedback/review on this PR. |
|
@FdezRomero CI is failing and awaiting your CLA, I wasn’t sure if you saw that. |
|
@benallfree Yes, I did and I signed the CLA, but I can't get the bot to rescan it. I tried with @googlebot rescan but didn't work, so I think it would fix itself if you do another commit. |
|
I'm happy for it to be in any version. Probably needs to be v13 now, since v12 was just released. |
…/puppeteer into expose-intercept-resolution-2
|
@Tyler-Murphy Spelling error fix moved to #7813 for v13 and removed from this PR so we can do this as a dot release. Thanks for that catch! |
|
I will try to find some time to review PRs next week. |
|
@sadym-chromium could you PTAL as well? |
|
Great work, thanks! I just got a bit confused by the |
|
@sadym-chromium Fixed, thank you! 👍 |
benallfree
force-pushed
the
expose-intercept-resolution-2
branch
from
6482cae to
3982bc4
Compare
What kind of change does this PR introduce?
New API methods on
HTTPRequestDid you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
#6735 introduced cooperative request intercepts and we are now starting to see adoption.
puppeteer-extrajust started berstend/puppeteer-extra#592 their support for cooperative mode. In the course of doing so, it became clear that exposing the intercept resolution state would be helpful along with a few doc clarifications.Does this PR introduce a breaking change?
No
Other information
Requesting review by @jschfflr in particular :)