-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webp to screenshot options #7565
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The change looks good from a technical point of view but it would be great if you could also update the documentation (docs/api.md
) and add a unit test (see screenshot.spec.ts
). Thanks!
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@jonchurch I already went ahead and addressed the outstanding comments to get this into the next release :) |
@jschfflr Yay! Thank you for getting this over the finish line 🥇 |
Sure, happy to help! |
closes: #5348
Not sure since when, but webp is an option in
Page.captureScreenshot
now.All that is needed is to allow users to pass
type: "webp"
through.After making said change to allow passing webp through as an option, this code successfully creates webp screenshots using either
type: "webp"
or using the.webp
extension from the filepath.Happy to take any help getting this mergeable, ie writing tests.
I'd upload a webp here but github doesn't support them!