feat: add page.emulateCPUThrottling #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrKoN Do you have a suggestion for how to test this feature in a better way? |
OrKoN
reviewed
Jun 22, 2021
OrKoN
reviewed
Jun 22, 2021
OrKoN
reviewed
Jun 22, 2021
OrKoN
approved these changes
Jun 22, 2021
mathiasbynens
changed the title
OrKoN
reviewed
Jun 22, 2021
tasneemkoushar
added a commit
that referenced
this pull request
Jun 22, 2021
* fix: modified comment for method product, platform and newPage * fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage * fix: corrected comments for JSONValue, asElement, evaluateHandle * fix: corrected comments for JSONValue, asElement, evaluateHandle * fix: added comments for some of the method * fix: added proper comments * fix: added comment for some methods in page.ts * fix: rectified the comments * fix: changed some of the comments * fix: added comments for 3 more methods of class page * fix: added comments for 3 more methods of class page * fix: added comments for 5 more methods in class page * fix: removed the extra whitespace * fix: added comments for 5 more method in page class * fix: added comments for 5 more methods in class page * fix: commented 12 more methods in class Page * fix: commented 12 methods in class Page * fix: commented 12 more methods in class Page * fix: commented 12 more methods in class Page * chore: fix typo in connection.spec.js (#7326) recieved -> received * chore: synchronize Bug 1710839: update comment about firefox preference remote.enabled (#7324) * fix: added comments for methods in class page * docs: add download location to the FAQ (#7339) Co-authored-by: Mathias Bynens <mathias@qiwi.be> * fix: added comments * fix: comments added * feat: add page.emulateCPUThrottling (#7343) * fix: added comments Co-authored-by: Jack Franklin <jacktfranklin@chromium.org> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: Julian Descottes <julian.descottes@gmail.com> Co-authored-by: Diego Fernandez <dfernandez79@users.noreply.github.com> Co-authored-by: Mathias Bynens <mathias@qiwi.be> Co-authored-by: Jan Scheffler <janscheffler@chromium.org>
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.