chore: drop support for Node.js 10 #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for shipping Puppeteer as JavaScript modules. Issue: #6753 BREAKING CHANGE: Node.js 10 is no longer supported.
mathiasbynens
force-pushed
the
drop-node-10
branch
from
44c2ad4 to
48a36b0
Compare
|
Regarding the tsconfig target - yeah I reckon we should target whatever the lowest Node we support supports? WDYT? Also not sure why there are so many Prettier related failures on CI; those shouldn't have made it through onto main :/ |
mathiasbynens
force-pushed
the
drop-node-10
branch
from
a3f30a1 to
be4361e
Compare
|
Apparently |
jackfranklin
approved these changes
May 17, 2021
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for shipping Puppeteer as JavaScript modules (#6753).
@jackfranklin I noticed that our tsconfig has
target(andmodule) set atESNext. Should we hardcode that at whatever our currently-supported Node.js versions support (in this case, that would beES2019)?