fix executablePath (arm64) #6495

alex2844 · 2020-10-09T08:39:23Z

const puppeteer = require('puppeteer-core');
(async () => {
  const browser = await puppeteer.launch({ executablePath: '/usr/bin/chromium' });
  await browser.close();
})();

Error: Failed to launch the browser process! spawn /usr/bin/chromium-browser ENOENT
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md

google-cla · 2020-10-09T08:39:31Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

alex2844 · 2020-10-09T08:42:55Z

@googlebot I signed it!

jackfranklin · 2020-10-12T09:10:39Z

src/node/BrowserFetcher.ts

-      console.error(`If you are on Ubuntu, you can install with: `);
-      console.error(`\n apt-get install chromium-browser\n`);
-      throw new Error();
+      fs.stat('/usr/bin/chromium', function (err, stats) {


(I'm not familiar with arm64) why would it maybe be in chromium-browser or chromium? Should we update the error message too?

@jackfranklin The error was updated

src/node/BrowserFetcher.ts

mathiasbynens · 2020-12-28T06:14:41Z

Suggested commit message:

feat: support fetching and launching on Apple M1

Issue: #6495, #6634, #6641, #6614

mathiasbynens · 2020-12-28T07:05:39Z

@alex2844 Could you please run npm run lint and fix the issues? https://travis-ci.com/github/puppeteer/puppeteer/jobs/465377239#L239-L304

Then we can merge this!

tylersmalley · 2021-01-05T22:22:26Z

Any way to get movement on this with a release? ❤️

connorlurring · 2021-01-05T22:37:16Z

Any way to get movement on this with a release? ❤️

+1 for this, willing to help @alex2844 get this over the line if necessary

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

google-cla · 2021-01-06T11:25:29Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

alex2844 · 2021-01-06T11:27:34Z

@googlebot I consent.

google-cla · 2021-01-06T11:27:51Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mathiasbynens · 2021-01-08T09:35:26Z

I’ll go ahead and land this, and will fix any remaining lint issues as a follow-up. Thanks, everyone!

Issue: #6495, #6634, #6641, #6614

This will fix Apple M1 machines once puppeteer/puppeteer#6495 lands

okonet · 2021-02-10T12:19:28Z

I still have issues installing puppeteer on M1 Mac since it's looking for the the executable to be in /usr/bin/chromium but the the homebrew installation installs packages to /opt/homebrew/bin on Big Sur so it still fails for me. Any suggestions how to resolve it?

karlhorky · 2021-03-24T15:28:54Z

I added the following to ~/.zshrc as suggested on #6622 (comment)

export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
export PUPPETEER_EXECUTABLE_PATH=`which chromium`

...and then used patch-package to modify the puppeteer package:

diff --git a/node_modules/puppeteer/lib/cjs/puppeteer/node/Launcher.js b/node_modules/puppeteer/lib/cjs/puppeteer/node/Launcher.js
index 835c74c..1d6e940 100644
--- a/node_modules/puppeteer/lib/cjs/puppeteer/node/Launcher.js
+++ b/node_modules/puppeteer/lib/cjs/puppeteer/node/Launcher.js
@@ -72,7 +72,7 @@ class ChromeLauncher {
         let chromeExecutable = executablePath;
         if (!executablePath) {
             if (os.arch() === 'arm64') {
-                chromeExecutable = '/usr/bin/chromium-browser';
+                chromeExecutable = '/opt/homebrew/bin/chromium';
             }
             else {
                 const { missingText, executablePath } = resolveExecutablePath(this);

phcoliveira · 2021-03-29T14:50:08Z

Is there a reason for not using an environment variable before the hardcoded path suggested by Homebrew? Chromium can be installed without using Homebrew, can it not?

chromeExecutable = process.env.CHROMIUM_EXECUTABLE_PATH || '/opt/homebrew/bin/chromium';

karlhorky · 2021-03-29T18:06:33Z

@phcoliveira, to me this looks great! Want to do a PR and see if the maintainers agree?

google-cla bot added the cla: no label Oct 9, 2020

google-cla bot added cla: yes and removed cla: no labels Oct 9, 2020

jackfranklin reviewed Oct 12, 2020

View reviewed changes

yhatt mentioned this pull request Nov 28, 2020

Cannot spawn Chromium with custom executablePath on Apple M1 #6634

Closed

yhatt mentioned this pull request Dec 17, 2020

Wrong assumption of Chrome exec path on Apple Silicon M1 #6641

Closed

eugene1g mentioned this pull request Dec 23, 2020

ExecutablePath option ignored #6614

Closed

mathiasbynens reviewed Dec 28, 2020

View reviewed changes

src/node/BrowserFetcher.ts Outdated Show resolved Hide resolved

mathiasbynens approved these changes Dec 28, 2020

View reviewed changes

tylersmalley pushed a commit to elastic/puppeteer that referenced this pull request Jan 6, 2021

fix(launcher): applies partial patch from puppeteer/pull/6495

2ebf748

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

alex2844 and others added 6 commits January 6, 2021 16:23

fix: executablePath on arm64

7539d29

fix: executablePath on arm64

1e271bb

fix: executablePath on arm64

f42a22d

fix: executablePath on arm64

e70903a

fix: executablePath on arm64

bebc45c

fix: executablePath on arm64

8501afd

alex2844 force-pushed the main branch from 966ca0b to 8501afd Compare January 6, 2021 11:25

google-cla bot added cla: no and removed cla: yes labels Jan 6, 2021

mathiasbynens merged this pull request into puppeteer:main Jan 8, 2021

mathiasbynens pushed a commit that referenced this pull request Jan 8, 2021

feat: support fetching and launching on Apple M1

9a8479a

Issue: #6495, #6634, #6641, #6614

controversial added a commit to controversial/resume that referenced this pull request Jan 12, 2021

Assume pre-installed Google Chrome instance

94ff475

This will fix Apple M1 machines once puppeteer/puppeteer#6495 lands

niklaas mentioned this pull request Jun 29, 2021

Install error on apple m1 silicon scullyio/scully#1383

Closed

honzajavorek mentioned this pull request Aug 10, 2022

Installation problem with MacOS M1 chip sindresorhus/pageres#420

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix executablePath (arm64) #6495

fix executablePath (arm64) #6495

alex2844 commented Oct 9, 2020

google-cla bot commented Oct 9, 2020

alex2844 commented Oct 9, 2020

jackfranklin Oct 12, 2020

alex2844 Oct 12, 2020

mathiasbynens commented Dec 28, 2020

mathiasbynens commented Dec 28, 2020

tylersmalley commented Jan 5, 2021 •

edited

Loading

connorlurring commented Jan 5, 2021

google-cla bot commented Jan 6, 2021

alex2844 commented Jan 6, 2021

google-cla bot commented Jan 6, 2021

mathiasbynens commented Jan 8, 2021

okonet commented Feb 10, 2021

karlhorky commented Mar 24, 2021

phcoliveira commented Mar 29, 2021

karlhorky commented Mar 29, 2021

fix executablePath (arm64) #6495

fix executablePath (arm64) #6495

Conversation

alex2844 commented Oct 9, 2020

google-cla bot commented Oct 9, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

alex2844 commented Oct 9, 2020

jackfranklin Oct 12, 2020

Choose a reason for hiding this comment

alex2844 Oct 12, 2020

Choose a reason for hiding this comment

mathiasbynens commented Dec 28, 2020

mathiasbynens commented Dec 28, 2020

tylersmalley commented Jan 5, 2021 • edited Loading

connorlurring commented Jan 5, 2021

google-cla bot commented Jan 6, 2021

alex2844 commented Jan 6, 2021

google-cla bot commented Jan 6, 2021

mathiasbynens commented Jan 8, 2021

okonet commented Feb 10, 2021

karlhorky commented Mar 24, 2021

phcoliveira commented Mar 29, 2021

karlhorky commented Mar 29, 2021

tylersmalley commented Jan 5, 2021 •

edited

Loading