-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: improve TS types for launching browsers (#6888)
This commit tidies up the quite confusing state of all the various types required to launch a browser. As we saw when upgrading DevTools (https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/test/conductor/hooks.ts;l=77), we had to define our launch options variable like so: ```ts const opts: puppeteer.LaunchOptions & puppeteer.ChromeArgOptions & puppeteer.BrowserOptions = { ... }; ``` This commit fixes that by introducing `AllNodeLaunchOptions`, which is defined as the intersection of all the above types. Additionally, the types defined as `ChromeArgOptions` are actually used for launching both Chrome and Firefox, so I have renamed them to `BrowserArgOptions`, and therefore this change is breaking because anyone using `ChromeArgOptions` in their types will need to switch. BREAKING CHANGE: renamed type `ChromeArgOptions` to `BrowserLaunchArgumentOptions` BREAKING CHANGE: renamed type `BrowserOptions` to `BrowserConnectOptions`
- v19.2.2
- v19.2.1
- v19.2.0
- v19.1.2
- v19.1.1
- v19.1.0
- v19.0.0
- v18.2.1
- v18.2.0
- v18.1.0
- v18.0.5
- v18.0.4
- v18.0.3
- v18.0.2
- v18.0.1
- v18.0.0
- v17.1.3
- v17.1.2
- v17.1.1
- v17.1.0
- v17.0.0
- v16.2.0
- v16.1.1
- v16.1.0
- v16.0.0
- v15.5.0
- v15.4.2
- v15.4.1
- v15.4.0
- v15.3.2
- v15.3.1
- v15.3.0
- v15.2.0
- v15.1.1
- v15.1.0
- v15.0.2
- v15.0.1
- v15.0.0
- v14.4.1
- v14.4.0
- v14.3.0
- v14.2.1
- v14.2.0
- v14.1.2
- v14.1.1
- v14.1.0
- v14.0.0
- v13.7.0
- v13.6.0
- v13.5.2
- v13.5.1
- v13.5.0
- v13.4.1
- v13.4.0
- v13.3.2
- v13.3.1
- v13.3.0
- v13.2.0
- v13.1.3
- v13.1.2
- v13.1.1
- v13.1.0
- v13.0.1
- v13.0.0
- v12.0.1
- v12.0.0
- v11.0.0
- v10.4.0
- v10.2.0
- v10.1.0
- v10.0.0
- v9.1.1
- v9.1.0
- v9.0.0
- v8.0.0
- testserver-v0.6.1
- testserver-v0.6.0
- puppeteer-v24.2.1
- puppeteer-v24.2.0
- puppeteer-v24.1.1
- puppeteer-v24.1.0
- puppeteer-v24.0.0
- puppeteer-v23.11.1
- puppeteer-v23.11.0
- puppeteer-v23.10.4
- puppeteer-v23.10.3
- puppeteer-v23.10.2
- puppeteer-v23.10.1
- puppeteer-v23.10.0
- puppeteer-v23.9.0
- puppeteer-v23.8.0
- puppeteer-v23.7.1
- puppeteer-v23.7.0
- puppeteer-v23.6.1
- puppeteer-v23.6.0
- puppeteer-v23.5.3
- puppeteer-v23.5.2
- puppeteer-v23.5.1
- puppeteer-v23.5.0
- puppeteer-v23.4.1
- puppeteer-v23.4.0
- puppeteer-v23.3.1
- puppeteer-v23.3.0
- puppeteer-v23.2.2
- puppeteer-v23.2.1
- puppeteer-v23.2.0
- puppeteer-v23.1.1
- puppeteer-v23.1.0
- puppeteer-v23.0.2
- puppeteer-v23.0.1
- puppeteer-v23.0.0
- puppeteer-v22.15.0
- puppeteer-v22.14.0
- puppeteer-v22.13.1
- puppeteer-v22.13.0
- puppeteer-v22.12.1
- puppeteer-v22.12.0
- puppeteer-v22.11.2
- puppeteer-v22.11.1
- puppeteer-v22.11.0
- puppeteer-v22.10.1
- puppeteer-v22.10.0
- puppeteer-v22.9.0
- puppeteer-v22.8.2
- puppeteer-v22.8.1
- puppeteer-v22.8.0
- puppeteer-v22.7.1
- puppeteer-v22.7.0
- puppeteer-v22.6.5
- puppeteer-v22.6.4
- puppeteer-v22.6.3
- puppeteer-v22.6.2
- puppeteer-v22.6.1
- puppeteer-v22.6.0
- puppeteer-v22.5.0
- puppeteer-v22.4.1
- puppeteer-v22.4.0
- puppeteer-v22.3.0
- puppeteer-v22.2.0
- puppeteer-v22.1.0
- puppeteer-v22.0.0
- puppeteer-v21.11.0
- puppeteer-v21.10.0
- puppeteer-v21.9.0
- puppeteer-v21.8.0
- puppeteer-v21.7.0
- puppeteer-v21.6.1
- puppeteer-v21.6.0
- puppeteer-v21.5.2
- puppeteer-v21.5.1
- puppeteer-v21.5.0
- puppeteer-v21.4.1
- puppeteer-v21.4.0
- puppeteer-v21.3.8
- puppeteer-v21.3.7
- puppeteer-v21.3.6
- puppeteer-v21.3.5
- puppeteer-v21.3.4
- puppeteer-v21.3.3
- puppeteer-v21.3.2
- puppeteer-v21.3.1
- puppeteer-v21.3.0
- puppeteer-v21.2.1
- puppeteer-v21.2.0
- puppeteer-v21.1.1
- puppeteer-v21.1.0
- puppeteer-v21.0.3
- puppeteer-v21.0.2
- puppeteer-v21.0.1
- puppeteer-v21.0.0
- puppeteer-v20.9.0
- puppeteer-v20.8.3
- puppeteer-v20.8.2
- puppeteer-v20.8.1
- puppeteer-v20.8.0
- puppeteer-v20.7.4
- puppeteer-v20.7.3
- puppeteer-v20.7.2
- puppeteer-v20.7.1
- puppeteer-v20.7.0
- puppeteer-v20.6.0
- puppeteer-v20.5.0
- puppeteer-v20.4.0
- puppeteer-v20.3.0
- puppeteer-v20.2.1
- puppeteer-v20.2.0
- puppeteer-v20.1.2
- puppeteer-v20.1.1
- puppeteer-v20.1.0
- puppeteer-v20.0.0
- puppeteer-v19.11.1
- puppeteer-v19.11.0
- puppeteer-v19.10.1
- puppeteer-v19.10.0
- puppeteer-v19.9.1
- puppeteer-v19.9.0
- puppeteer-v19.8.5
- puppeteer-v19.8.4
- puppeteer-v19.8.3
- puppeteer-v19.8.2
- puppeteer-v19.8.1
- puppeteer-v19.8.0
- puppeteer-v19.7.5
- puppeteer-v19.7.4
- puppeteer-v19.7.3
- puppeteer-v19.7.2
- puppeteer-v19.7.1
- puppeteer-v19.7.0
- puppeteer-v19.6.3
- puppeteer-v19.6.2
- puppeteer-v19.6.1
- puppeteer-v19.6.0
- puppeteer-v19.5.2
- puppeteer-v19.5.1
- puppeteer-v19.5.0
- puppeteer-v19.4.1
- puppeteer-v19.4.0
- puppeteer-v19.3.0
- puppeteer-core-v24.2.1
- puppeteer-core-v24.2.0
- puppeteer-core-v24.1.1
- puppeteer-core-v24.1.0
- puppeteer-core-v24.0.0
- puppeteer-core-v23.11.1
- puppeteer-core-v23.11.0
- puppeteer-core-v23.10.4
- puppeteer-core-v23.10.3
- puppeteer-core-v23.10.2
- puppeteer-core-v23.10.1
- puppeteer-core-v23.10.0
- puppeteer-core-v23.9.0
- puppeteer-core-v23.8.0
- puppeteer-core-v23.7.1
- puppeteer-core-v23.7.0
- puppeteer-core-v23.6.1
- puppeteer-core-v23.6.0
- puppeteer-core-v23.5.3
- puppeteer-core-v23.5.2
- puppeteer-core-v23.5.1
- puppeteer-core-v23.5.0
- puppeteer-core-v23.4.1
- puppeteer-core-v23.4.0
- puppeteer-core-v23.3.1
- puppeteer-core-v23.3.0
- puppeteer-core-v23.2.2
- puppeteer-core-v23.2.1
- puppeteer-core-v23.2.0
- puppeteer-core-v23.1.1
- puppeteer-core-v23.1.0
- puppeteer-core-v23.0.2
- puppeteer-core-v23.0.1
- puppeteer-core-v23.0.0
- puppeteer-core-v22.15.0
- puppeteer-core-v22.14.0
- puppeteer-core-v22.13.1
- puppeteer-core-v22.13.0
- puppeteer-core-v22.12.1
- puppeteer-core-v22.12.0
- puppeteer-core-v22.11.2
- puppeteer-core-v22.11.1
- puppeteer-core-v22.11.0
- puppeteer-core-v22.10.1
- puppeteer-core-v22.10.0
- puppeteer-core-v22.9.0
- puppeteer-core-v22.8.2
- puppeteer-core-v22.8.1
- puppeteer-core-v22.8.0
- puppeteer-core-v22.7.1
- puppeteer-core-v22.7.0
- puppeteer-core-v22.6.5
- puppeteer-core-v22.6.4
- puppeteer-core-v22.6.3
- puppeteer-core-v22.6.2
- puppeteer-core-v22.6.1
- puppeteer-core-v22.6.0
- puppeteer-core-v22.5.0
- puppeteer-core-v22.4.1
- puppeteer-core-v22.4.0
- puppeteer-core-v22.3.0
- puppeteer-core-v22.2.0
- puppeteer-core-v22.1.0
- puppeteer-core-v22.0.0
- puppeteer-core-v21.11.0
- puppeteer-core-v21.10.0
- puppeteer-core-v21.9.0
- puppeteer-core-v21.8.0
- puppeteer-core-v21.7.0
- puppeteer-core-v21.6.1
- puppeteer-core-v21.6.0
- puppeteer-core-v21.5.2
- puppeteer-core-v21.5.1
- puppeteer-core-v21.5.0
- puppeteer-core-v21.4.1
- puppeteer-core-v21.4.0
- puppeteer-core-v21.3.8
- puppeteer-core-v21.3.7
- puppeteer-core-v21.3.6
- puppeteer-core-v21.3.5
- puppeteer-core-v21.3.4
- puppeteer-core-v21.3.3
- puppeteer-core-v21.3.2
- puppeteer-core-v21.3.1
- puppeteer-core-v21.3.0
- puppeteer-core-v21.2.1
- puppeteer-core-v21.2.0
- puppeteer-core-v21.1.1
- puppeteer-core-v21.1.0
- puppeteer-core-v21.0.3
- puppeteer-core-v21.0.2
- puppeteer-core-v21.0.1
- puppeteer-core-v21.0.0
- puppeteer-core-v20.9.0
- puppeteer-core-v20.8.3
- puppeteer-core-v20.8.2
- puppeteer-core-v20.8.1
- puppeteer-core-v20.8.0
- puppeteer-core-v20.7.4
- puppeteer-core-v20.7.3
- puppeteer-core-v20.7.2
- puppeteer-core-v20.7.1
- puppeteer-core-v20.7.0
- puppeteer-core-v20.6.0
- puppeteer-core-v20.5.0
- puppeteer-core-v20.4.0
- puppeteer-core-v20.3.0
- puppeteer-core-v20.2.1
- puppeteer-core-v20.2.0
- puppeteer-core-v20.1.2
- puppeteer-core-v20.1.1
- puppeteer-core-v20.1.0
- puppeteer-core-v20.0.0
- puppeteer-core-v19.11.1
- puppeteer-core-v19.11.0
- puppeteer-core-v19.10.1
- puppeteer-core-v19.10.0
- puppeteer-core-v19.9.1
- puppeteer-core-v19.9.0
- puppeteer-core-v19.8.5
- puppeteer-core-v19.8.4
- puppeteer-core-v19.8.3
- puppeteer-core-v19.8.1
- puppeteer-core-v19.8.0
- puppeteer-core-v19.7.5
- puppeteer-core-v19.7.4
- puppeteer-core-v19.7.3
- puppeteer-core-v19.7.2
- puppeteer-core-v19.7.1
- puppeteer-core-v19.7.0
- puppeteer-core-v19.6.3
- puppeteer-core-v19.6.2
- puppeteer-core-v19.6.1
- puppeteer-core-v19.6.0
- puppeteer-core-v19.5.2
- puppeteer-core-v19.5.1
- puppeteer-core-v19.5.0
- puppeteer-core-v19.4.1
- puppeteer-core-v19.4.0
- puppeteer-core-v19.3.0
- puppeteer-core-v19.2.2
- puppeteer-core-v19.2.1
- puppeteer-core-v19.2.0
- puppeteer-core-v19.1.1
- puppeteer-core-v19.1.0
- puppeteer-core-v19.0.0
- puppeteer-core-v18.2.1
- puppeteer-core-v18.2.0
- ng-schematics-v0.7.0
- ng-schematics-v0.6.1
- ng-schematics-v0.6.0
- ng-schematics-v0.5.6
- ng-schematics-v0.5.5
- ng-schematics-v0.5.4
- ng-schematics-v0.5.3
- ng-schematics-v0.5.2
- ng-schematics-v0.5.1
- ng-schematics-v0.5.0
- ng-schematics-v0.4.0
- ng-schematics-v0.3.0
- ng-schematics-v0.2.0
- ng-schematics-v0.1.0
- browsers-v2.7.1
- browsers-v2.7.0
- browsers-v2.6.1
- browsers-v2.6.0
- browsers-v2.5.0
- browsers-v2.4.1
- browsers-v2.4.0
- browsers-v2.3.1
- browsers-v2.3.0
- browsers-v2.2.4
- browsers-v2.2.3
- browsers-v2.2.2
- browsers-v2.2.1
- browsers-v2.2.0
- browsers-v2.1.0
- browsers-v2.0.1
- browsers-v2.0.0
- browsers-v1.9.1
- browsers-v1.9.0
- browsers-v1.8.0
- browsers-v1.7.1
- browsers-v1.7.0
- browsers-v1.6.0
- browsers-v1.5.1
- browsers-v1.5.0
- browsers-v1.4.6
- browsers-v1.4.5
- browsers-v1.4.4
- browsers-v1.4.3
- browsers-v1.4.2
- browsers-v1.4.1
- browsers-v1.4.0
- browsers-v1.3.0
- browsers-v1.2.0
- browsers-v1.1.0
- browsers-v1.0.1
- browsers-v1.0.0
- browsers-v0.5.0
- browsers-v0.4.1
- browsers-v0.4.0
- browsers-v0.3.3
- browsers-v0.3.2
- browsers-v0.3.1
- browsers-v0.3.0
- browsers-v0.2.0
- browsers-v0.1.1
- browsers-v0.1.0
- browsers-v0.0.5
- browsers-v0.0.4
- browsers-v0.0.3
- browsers-v0.0.2
- browsers-v0.0.1
1 parent
be7c229
commit 98c8145
Showing
6 changed files
with
124 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters