Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requirements.txt file #2029

Merged
merged 9 commits into from
Oct 28, 2020
Merged

Add requirements.txt file #2029

merged 9 commits into from
Oct 28, 2020

Conversation

romanroibu
Copy link
Contributor

@romanroibu romanroibu commented Oct 15, 2020 •
edited
Loading

This PR extracts Python dependencies from the documentation file, and puts them into requirements.txt such that it can be used with pip.

Tested:

  • ✅ Windows
  • ✅ Ubuntu
  • ✅ macOS

Todo:

  • Add pyproject.toml to PyAV package (Add pyproject.toml file PyAV#25)
  • Make a new release for PyAV
  • Make a new release for pyndsi
  • Update requirements.txt to point to newly released PyAV and pyndsi

ClickUp

papr
papr suggested changes Oct 20, 2020
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@romanroibu romanroibu mentioned this pull request Oct 21, 2020
Merged
papr
papr suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@papr papr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install wheel in order to avoid legacy python setup.py installbuilds.

docs/dependencies-macos.md Outdated Show resolved Hide resolved
docs/dependencies-ubuntu17.md Outdated Show resolved Hide resolved
docs/dependencies-ubuntu18.md Outdated Show resolved Hide resolved
@romanroibu romanroibu requested a review from papr October 28, 2020 13:27
@papr papr marked this pull request as ready for review October 28, 2020 13:32
@papr papr merged commit 683fdf6 into develop Oct 28, 2020
@papr papr deleted the add-requirements-txt branch October 28, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papr papr papr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanroibu @papr