Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: tests.yml - try MT_CPU: 2 #3592

Merged
merged 1 commit into from
Jan 3, 2025
Merged

CI: tests.yml - try MT_CPU: 2 #3592

merged 1 commit into from
Jan 3, 2025

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Jan 2, 2025

Description

Many of the CI runs have intermittent failures and/or intermittent retries. These often happen when tests involving clustered servers are running parallel. Currently, Windows & Ubuntu CI runs on x86-64 systems with two h/t cores. macOS 13 runs on the same. macOS 14 and 15 run on three arm cores.

This PR limits the number of Minitest threads running parallel testing to two (MT_CPU = 2). It will probably slow testing down, but we should have fewer failures and fewer test retries, which saves time.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Jan 3, 2025
@github-actions github-actions bot added waiting-for-merge and removed waiting-for-review Waiting on review from anyone labels Jan 3, 2025
@MSP-Greg MSP-Greg merged commit 2dcbb56 into puma:master Jan 3, 2025
87 checks passed
@MSP-Greg MSP-Greg deleted the 00-mt-cpu-2 branch January 3, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants