Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off SIGUSR2 trapping #3570

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

mohamedhafez
Copy link
Contributor

@mohamedhafez mohamedhafez commented Dec 3, 2024

This option is necessary for compatibility with Java Flight Recorder, a performance monitoring and diagnostic tool used with JRuby and TruffleRuby

Closes #3567

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Dec 3, 2024
@mohamedhafez mohamedhafez force-pushed the skip_usr2 branch 2 times, most recently from 19be5c7 to 8a199d8 Compare December 16, 2024 10:37
This option is necessary for compatibility with Java Flight Recorder,
a performance monitoring and diagnostic tool used with JRuby and
TruffleRuby.
@dentarg dentarg merged commit f5e4b77 into puma:master Dec 30, 2024
78 checks passed
@MSP-Greg MSP-Greg added feature jruby and removed waiting-for-review Waiting on review from anyone labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to skip SIGUSR2 handling so we can use Java Flight Recorder
3 participants