Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test/test_puma_server.rb - fixup auto_trim tests #3561

Merged
merged 1 commit into from
Nov 23, 2024
Merged

CI: test/test_puma_server.rb - fixup auto_trim tests #3561

merged 1 commit into from
Nov 23, 2024

Conversation

MSP-Greg
Copy link
Member

Description

Fixup failing tests in test/test_puma_server.rb

@joshuay03

Look ok to you? If I revert the changes to server.rb in #3384, test_auto_trim_with_fixed_pool_size fails. Also, one of the current tests raises in a thread, which stops CI...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Nov 23, 2024
joshuay03
joshuay03 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@joshuay03 joshuay03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was addressing in #3560 but I like this better 👍🏽

@joshuay03 joshuay03 mentioned this pull request Nov 23, 2024
Merged
@nateberkopec nateberkopec merged commit 0e22c0a into puma:master Nov 23, 2024
77 of 78 checks passed
@MSP-Greg MSP-Greg deleted the 00-ci-thread-pool-fix branch November 23, 2024 22:20
@MSP-Greg MSP-Greg removed the waiting-for-review Waiting on review from anyone label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuay03 joshuay03 joshuay03 approved these changes

Assignees
No one assigned
Labels
CI / Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSP-Greg @joshuay03 @nateberkopec