Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fixup test/test_web_concurrency_auto.rb #3545

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 5, 2024

Description

  1. Add concurrent-ruby to the main Gemfile.
  2. Fixup test_web_concurrency_with_concurrent_ruby_available
  3. Add test_web_concurrency_with_concurrent_ruby_unavailable
  4. Remove files in test/web_concurrency_test folder

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@MSP-Greg MSP-Greg merged commit 6f41426 into puma:master Nov 5, 2024
78 checks passed
@MSP-Greg MSP-Greg deleted the 00-web-concurrency branch November 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants