Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove unnecessary rake task test:all #3543

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

stadniklksndr
Copy link
Contributor

@stadniklksndr stadniklksndr commented Nov 2, 2024

Description

The task rake test:all is the same as rake test. Is there any reason it still needs to exist, aside from the different description? Does anybody still use rake test:all for running tests?

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg
Copy link
Member

dentarg commented Nov 7, 2024

Yeah it is a bit confusing to have two tasks doing the same thing, so I think we can remove test:all. Let's do only that and not all the ' -> " changes.

@dentarg
Copy link
Member

dentarg commented Nov 7, 2024

test:all had a purpose until #2347

@dentarg dentarg added waiting-for-changes Waiting on changes from the requestor CI / Testing labels Nov 7, 2024
This reverts commit 13f9d55.
@stadniklksndr
Copy link
Contributor Author

@dentarg ready

@dentarg dentarg merged commit 271e4d0 into puma:master Nov 8, 2024
77 of 78 checks passed
@dentarg dentarg removed the waiting-for-changes Waiting on changes from the requestor label Nov 8, 2024
@dentarg dentarg changed the title Delete unnecessary task CI: remove unnecessary rake task test:all Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants