Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add after_refork hook #3386

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Add after_refork hook #3386

merged 5 commits into from
Nov 27, 2024

Conversation

Drakula2k
Copy link
Contributor

Description

Adds after_refork hook to be able to re-create the resources that were removed in on_refork on the worker 0 (Mongo connections in my use case).

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@johnnyshields
Copy link
Contributor

johnnyshields commented May 20, 2024 •
edited
Loading

@nateberkopec the use case for after_refork is:

  • We use before_refork to disconnect any active database sockets on worker0
  • We use on_worker_boot to reconnect database/restart monitoring threads on the grandchild instance
  • However, there is currently no way to reconnect on worker0; worker0 stays disconnected even after forking.

Note that after_refork triggers only on worker0 and not on the grandchilds.

@dentarg dentarg added feature waiting-for-review Waiting on review from anyone labels Jun 5, 2024
@johnnyshields
Copy link
Contributor

@nateberkopec can you please take a look at this?

@johnnyshields
Copy link
Contributor

johnnyshields commented Aug 15, 2024 •
edited
Loading

We've been using this branch in prod for 3+ months with no issue--it completely fixed the problem we were seeing.

@johnnyshields
Copy link
Contributor

johnnyshields commented Nov 26, 2024 •
edited
Loading

@nateberkopec @dentarg may we ask to get this reviewed and merged?

@nateberkopec can you also enable "Update Branch" button in the GH settings?

@Drakula2k
Copy link
Contributor Author

@johnnyshields the button is accessible to me, done it, the build still passes

@nateberkopec nateberkopec merged commit e058301 into puma:master Nov 27, 2024
78 checks passed
@nateberkopec
Copy link
Member

Thanks for your patience 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature waiting-for-review Waiting on review from anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Drakula2k @johnnyshields @nateberkopec @dentarg