Avoid spawning Threadpool#trim thread if pool size is fixed
#3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
avoid-spawning-trim-thread-if-pool-size-is-fixed
branch
2 times, most recently
from
80a764b to
97baf4e
Compare
joshuay03
commented
May 19, 2024
| auto_trim_time = 3 | ||
| server_run(min_threads: 2, max_threads: 2, auto_trim_time: auto_trim_time) | ||
| sleep 1 # wait for possible initial trim on run | ||
| thread_pool_expect false, :trim, nil, after: auto_trim_time |
|
@rus-max Ah I did not see that, thanks! I'll leave this open cause I took a different approach with the tests. I'll add @OuYangJinTing as a co-author if the maintainers choose to go with this PR. |
joshuay03
force-pushed
the
avoid-spawning-trim-thread-if-pool-size-is-fixed
branch
from
97baf4e to
fed4d4a
Compare
7 tasks
joshuay03
force-pushed
the
avoid-spawning-trim-thread-if-pool-size-is-fixed
branch
from
fed4d4a to
60d3de6
Compare
Co-authored-by: ouyangjinting <OuYangJinTing@users.noreply.github.com>
joshuay03
force-pushed
the
avoid-spawning-trim-thread-if-pool-size-is-fixed
branch
from
60d3de6 to
e556608
Compare
7 tasks
|
That was really sweet that you both added each other as co-author ❤️ I like the tests on this one a bit more, so I'll go with this one. |
joshuay03
deleted the
avoid-spawning-trim-thread-if-pool-size-is-fixed
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #3383 I found that a thread was being spawned to trim the server's thread pool's threads every
:auto_trim_timeseconds regardless of whether or not the pool needed trimming, which would only be when the thread count is configured to scale automatically i.e. min != max.This PR ensures that specific thread is only spawned if the thread count is not fixed.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.