Allow alternative schemes in Binder #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomurb
force-pushed
the
3343-restrict-cipher-cuits-tls-1-3
branch
from
9e61153 to
e9353b6
Compare
dentarg
changed the title
|
It would be good to document / show how one can use this (it is not entirely clear to me, even when I've read the linked issue, but I have also never developed a plugin for Puma) Can something be added to https://github.com/puma/puma/blob/master/docs/plugins.md? |
dentarg
added
waiting-for-changes
|
I've added some documentation. I also didn't develop any plugins. I don't know how to write an example. I could maybe add that link for context and add how that change would make difference for acme-puma codebase? (change of the method name, and removal of Does that sound right? |
tomurb
force-pushed
the
3343-restrict-cipher-cuits-tls-1-3
branch
from
7c862e5 to
e829dd1
Compare
I think that would be good |
tomurb
force-pushed
the
3343-restrict-cipher-cuits-tls-1-3
branch
from
e829dd1 to
49785dc
Compare
tomurb
force-pushed
the
3343-restrict-cipher-cuits-tls-1-3
branch
from
88b1f58 to
edaf98a
Compare
dentarg
added
waiting-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for adding
before_parsehooks to theBinder#parsemethod.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.Closes #3302